Update maintainer information in README#739
Merged
Merged
Conversation
Added @akramj13 as a maintainer in the README.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| ## Created by | ||
|
|
||
| Originally created by <a href="https://github.com/FuJacob">@FuJacob</a>, now developed and maintained by <a href="https://github.com/FuJacob">@FuJacob</a> and <a href="https://github.com/jam-cai">@jam-cai</a>. | ||
| Originally created by <a href="https://github.com/FuJacob">@FuJacob</a>, now developed and maintained by <a href="https://github.com/FuJacob">@FuJacob</a>, <a href="https://github.com/jam-cai">@jam-cai</a>. and <a href="https://github.com/akramj13">@akramj13</a> |
Contributor
There was a problem hiding this comment.
@jam-cai. It now reads "@jam-cai. and @akramj13", which breaks the sentence and leaves the final entry without a terminal period. The comma-separated list should use ", and" before the last entry, with the period moved to the very end.
Suggested change
| Originally created by <a href="https://github.com/FuJacob">@FuJacob</a>, now developed and maintained by <a href="https://github.com/FuJacob">@FuJacob</a>, <a href="https://github.com/jam-cai">@jam-cai</a>. and <a href="https://github.com/akramj13">@akramj13</a> | |
| Originally created by <a href="https://github.com/FuJacob">@FuJacob</a>, now developed and maintained by <a href="https://github.com/FuJacob">@FuJacob</a>, <a href="https://github.com/jam-cai">@jam-cai</a>, and <a href="https://github.com/akramj13">@akramj13</a>. |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added @akramj13 as a maintainer in the README.
Summary
Validation
Linked issues
Risk / rollout notes
Greptile Summary
This PR adds
@akramj13as a new maintainer in the README's "Created by" section. The change is documentation-only and carries no functional risk.@jam-caiwas not moved to the end of the new sentence; instead a. andfragment was introduced mid-line, making the sentence grammatically broken and leaving the new entry without a closing period.Confidence Score: 4/5
Safe to merge once the punctuation in the 'Created by' line is corrected.
The only change is a one-line documentation update. A misplaced period results in broken sentence structure ('. and @akramj13' with no trailing period), which will be visible to anyone reading the README.
README.md — the 'Created by' sentence has a stray mid-sentence period and no terminal period.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[README.md - Created by section] --> B[FuJacob - original creator & maintainer] A --> C[jam-cai - maintainer] A --> D[akramj13 - new maintainer added by this PR]Reviews (1): Last reviewed commit: "Update maintainer information in README" | Re-trigger Greptile